Skip to content

Revert "Use the same DISubprogram for each instance of the same inline function within the caller" #115232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2023
Merged

Revert "Use the same DISubprogram for each instance of the same inline function within the caller" #115232

merged 1 commit into from
Aug 26, 2023

Conversation

wesleywiser
Copy link
Member

This reverts commit 687bffa.

Reverting to resolve ICEs reported on nightly.

cc @dpaoliello

Fixes #115156

@wesleywiser
Revert "Use the same DISubprogram for each instance of the same inlin…
d0b2c4f 
…ed function within the caller"

This reverts commit 687bffa.

Reverting to resolve ICEs reported on nightly.
@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 25, 2023
@rustbot
Copy link
Collaborator

rustbot commented Aug 25, 2023

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

@tmiasko
Copy link
Contributor

tmiasko commented Aug 26, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

📌 Commit d0b2c4f has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@bors
Copy link
Collaborator

bors commented Aug 26, 2023

⌛ Testing commit d0b2c4f with merge 42857db...

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

☀️ Test successful - checks-actions
Approved by: tmiasko
Pushing 42857db to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2023
@bors bors merged commit 42857db into rust-lang:master Aug 26, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 26, 2023
@bors bors mentioned this pull request Aug 26, 2023
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (42857db): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.8% [0.8%, 0.8%] 1
Regressions ❌
(secondary)		 1.1% [0.4%, 1.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.8% [0.8%, 0.8%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)		 2.4% [2.0%, 2.7%] 2
Improvements ✅
(primary)		 -0.8% [-0.8%, -0.8%] 1
Improvements ✅
(secondary)		 -1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) -0.2% [-0.8%, 0.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.4% [0.0%, 0.8%] 62
Regressions ❌
(secondary)		 0.4% [0.0%, 1.6%] 18
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [0.0%, 0.8%] 62

Bootstrap: 631.395s -> 631.501s (0.02%)
Artifact size: 315.55 MiB -> 315.37 MiB (-0.06%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidtwco davidtwco

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
Development

Successfully merging this pull request may close these issues.

Compiler SIGSEGV When Compiling hartex-discord-worker
6 participants
@wesleywiser @rustbot @tmiasko @bors @rust-timer @davidtwco